Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Spark Example Notebook + install with [all] #15

Merged
merged 8 commits into from
Mar 14, 2022
Merged

Add Spark Example Notebook + install with [all] #15

merged 8 commits into from
Mar 14, 2022
+169 −65

Conversation

winfried-ripken
Copy link
Contributor

@winfried-ripken winfried-ripken commented Mar 14, 2022 •
edited
Loading

Description

Add tutorial how to use preprocessing with spark (8) + reference it in docu.

Small changes:

  • readme.md with instal [all] option
  • remove colab buttons

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactoring including code style reformatting
  • Other (please describe):

Checklist:

  • I have read the [contributing guideline doc] () (external only)
  • I have signed the [CLA] () (external only)
  • Lint and unit tests pass locally with my changes
  • I have kept the PR small so that it can be easily reviewed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • All dependency changes have been reflected in the pip requirement files.

@winfried-ripken winfried-ripken changed the title Change readme.md to install with option [all] Add Spark Example Notebook + install with [all] Mar 14, 2022
@winfried-ripken winfried-ripken marked this pull request as ready for review March 14, 2022 17:37
TiansuYu
TiansuYu suggested changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@TiansuYu TiansuYu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing needs to be changed. Others LGTM

TiansuYu
TiansuYu reviewed Mar 14, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
TiansuYu
TiansuYu reviewed Mar 14, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
AlpAribal
AlpAribal suggested changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@AlpAribal AlpAribal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the beta testers will be able to run this nb without additional help. Other changes lgtm.

examples/08.Spark_Preprocessing.ipynb Show resolved Hide resolved
examples/08.Spark_Preprocessing.ipynb Outdated Show resolved Hide resolved
@winfried-ripken winfried-ripken merged commit d5b7a30 into main Mar 14, 2022
@winfried-ripken winfried-ripken deleted the winnie-spark-example branch March 14, 2022 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlirezaSohofi AlirezaSohofi AlirezaSohofi approved these changes

@TiansuYu TiansuYu TiansuYu requested changes

@AlpAribal AlpAribal AlpAribal requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@winfried-ripken @AlpAribal @TiansuYu @AlirezaSohofi